activate repos.json #398
Merged
activate repos.json #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-rister
commented
Sep 9, 2024
|
This is almost complete, just need to sort out a few details with input from others (@rafaelfolco , @atheurer) before taking this out of draft mode and letting the full CI run. |
k-rister
force-pushed
the
dev-kmr
branch
2 times, most recently
from
8190f81 to
19c1e4e
Compare
- This makes the repository URLs consistent with the way that Crucible has previously been installed which allows for a more seamless transition when existing installations are updated. - From a github.com perspective it appears that the ".git" extension is optional -- a "git clone" will work with or without it but the resulting repository does have slightly different configuration details depending as a result (ie. the remote URL is not the same)
- make it easier to distinguish one test from another - add verbose output to make debugging easier - ensure that the code in the "local" repo is being tested instead of what is in the upstream repo (using --git-repo) - eliminate STDOUT buffering because a lot of the output comes on STDERR and it is desirable to maintain output ordering
|
This PR is ready for (final) review. |
|
Waiting to merge this until Monday, Sept. 23, 2024 in case it causes any troubles that need to be dealt with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.