[spec] Stable releases for Crucible installs #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a mechanism for installing stable releases that are "locked- down".
k-rister
reviewed
Jun 27, 2024
Comment on lines
+20
to
+29
| #project-name project-type git-repo-url branch | ||
| rickshaw core /rickshaw master | ||
| multiplex core /multiplex master | ||
| roadblock core /roadblock master | ||
| ... | ||
| hwlatdetect benchmark /bench-hwlatdetect main | ||
| tracer benchmark /bench-tracer main | ||
| ... | ||
| ftrace tool /tool-ftrace master | ||
| testing doc /testing-repo master |
There was a problem hiding this comment.
Do you think we should switch to the "new" subproject config idea (JSON) as part of this?
There was a problem hiding this comment.
I think so. Not a dependency, just a convenience, as we are changing crucible config/default_projects.
| ## Proposed change | ||
| "Locked down" release by pinning all sub-projects to a commit that is | ||
| verified by CI after code merges. Sub-projects includes core and benchmark | ||
| repositories. Stable releases must be labeled to be an "out of the box" |
There was a problem hiding this comment.
Not sure I follow what you mean by "out of the box" here...
There was a problem hiding this comment.
For regression testing, "out of the box" Crucible would be crucible-2024.2, not the upstream latest merged code. We can avoid this and just call it a stable release 2024.2.
|
on behalf of #351 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a mechanism for installing stable releases that are "locked- down".