Addresses BACKLOG-40051: new endpoint execute schedule permission #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
afrjorge
reviewed
Mar 20, 2024
core/src/main/java/org/pentaho/platform/web/http/api/resources/SchedulerResource.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
afrjorge
reviewed
Mar 21, 2024
| @@ -197,84 +198,74 @@ public Job createJob( JobScheduleRequest scheduleRequest ) | |||
| /** | |||
| * Wrapper function around {@link SchedulerOutputPathResolver#resolveOutputFilePath()} calls | |||
| * {@link #getSchedulerOutputPathResolver(JobScheduleRequest)} to get instance. | |||
| * @param scheduleRequest | |||
There was a problem hiding this comment.
We should complete the documentation, or leave it as is for now.
There was a problem hiding this comment.
I understand that completing the documentation is important, however, in this particular case, I was not fully aware of the details regarding the implementation which could have resulted in inaccurate information. Leaving an empty tag in the documentation should be avoided.
Pancho7
approved these changes
Mar 21, 2024
afrjorge
reviewed
Mar 21, 2024
...src/test/java/org/pentaho/platform/web/http/api/resources/services/SchedulerServiceTest.java
Outdated
Show resolved
Hide resolved
afrjorge
reviewed
Mar 21, 2024
...src/test/java/org/pentaho/platform/web/http/api/resources/services/SchedulerServiceTest.java
Show resolved
Hide resolved
|
Note:Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system. |
✅ Build finished in 6m 54sBuild command: mvn clean verify -B -e -Daudit -amd -Djs.no.sandbox -pl core👌 All tests passed! Tests run: 223, Failures: 0, Skipped: 12 Test Results ℹ️ This is an automatic message |
afrjorge
approved these changes
Mar 21, 2024
ddiroma
added a commit
that referenced
this pull request
Mar 24, 2024
)" This reverts commit f232a34.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pentaho/millenniumfalcon please review
Depends on
pentaho/pentaho-platform#5560