Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Invalid database connection is saved AND used despite "CANCEL" #5798

Merged
merged 6 commits into from
Nov 29, 2024
Merged

fix: Invalid database connection is saved AND used despite "CANCEL" #5798

merged 6 commits into from
Nov 29, 2024

Conversation

befc
Copy link
Contributor

@befc befc commented Nov 27, 2024 •
edited
Loading

This PR needs to be merged together with pentaho/data-access#1295

@pentaho/tatooine_dev please review

@befc befc requested a review from a team as a code owner November 27, 2024 14:36
@befc befc mentioned this pull request Nov 27, 2024
Merged
@pentaho pentaho deleted a comment from buildguy Nov 29, 2024
@pentaho pentaho deleted a comment from buildguy Nov 29, 2024
@befc befc force-pushed the BISERVER-15144 branch 2 times, most recently from f30ee82 to 453a87d Compare November 29, 2024 17:21
@buildguy

This comment has been minimized.

Sign in to view
@hitachivantarasonarqube HitachiVantaraSonarQube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
52.3% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@buildguy
Copy link
Collaborator

👍 Frogbot scanned this pull request and did not find any new security issues.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

@buildguy
Copy link
Collaborator

✅ Build finished in 24m 58s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl core,extensions

👌 All tests passed!

Tests run: 2134, Failures: 0, Skipped: 5    Test Results

ℹ️ This is an automatic message

smmribeiro
smmribeiro approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@smmribeiro smmribeiro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pentaho pentaho deleted a comment from buildguy Nov 29, 2024
@pentaho pentaho deleted a comment from buildguy Nov 29, 2024
@pentaho pentaho deleted a comment from buildguy Nov 29, 2024
@smmribeiro smmribeiro merged commit 55e15ac into pentaho:master Nov 29, 2024
7 of 8 checks passed
@smmribeiro smmribeiro mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joana-fb joana-fb joana-fb approved these changes

@smmribeiro smmribeiro smmribeiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@befc @buildguy @smmribeiro @joana-fb