Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKLOG-36846] Setting Focus on Textbox #5214

Open
wants to merge 1 commit into
base: wcag
Choose a base branch
from
Open

[BACKLOG-36846] Setting Focus on Textbox #5214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions user-console/src/main/java/org/pentaho/mantle/client/admin/ContentCleanerPanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ public void cancelPressed() {
AbstractWizardDialog.ScheduleDialogType.SCHEDULER );
editSchedule.setShowSuccessDialog( false );
editSchedule.addCustomPanel( scheduleLabelPanel, DockPanel.NORTH );
editSchedule.setFocusWidget( scheduleTextBox );
Copy link
Contributor

@dcleao dcleao Feb 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like previously said in #5210 (comment), I believe that you should not need to call setFocusWidget( . ).

Is it not the first "tababble" element of the dialog?

If the code which sets the default focus is failing, we should fix that instead. See https://github.com/pentaho/pentaho-commons-gwt-modules/blob/wcag/widgets/src/main/java/org/pentaho/gwt/widgets/client/dialogs/DialogBox.java#L204.

editSchedule.center();
}
} );
Expand Down