Fix 500 error on API DELETE endpoints

pentacent · Nov 3, 2023 · 6126317 · 6126317
1 parent ad9f47d
commit 6126317
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Fixed
+- API DELETE endpoints for campaigns, contacts, segments now return the
+  correct 204 response
+
 
 ## Version 0.12.8
 

diff --git a/lib/keila_web/api/controllers/api_campaign_controller.ex b/lib/keila_web/api/controllers/api_campaign_controller.ex
@@ -104,7 +104,7 @@ defmodule KeilaWeb.ApiCampaignController do
     Mailings.delete_project_campaigns(project_id(conn), [id])
 
     conn
-    |> put_status(204)
+    |> send_resp(:no_content, "")
   end
 
   operation(:deliver,

diff --git a/lib/keila_web/api/controllers/api_contact_controller.ex b/lib/keila_web/api/controllers/api_contact_controller.ex
@@ -129,7 +129,7 @@ defmodule KeilaWeb.ApiContactController do
     Contacts.delete_project_contacts(project_id(conn), filter: %{"id" => id})
 
     conn
-    |> put_status(204)
+    |> send_resp(:no_content, "")
   end
 
   defp project_id(conn), do: conn.assigns.current_project.id

diff --git a/lib/keila_web/api/controllers/api_segment_controller.ex b/lib/keila_web/api/controllers/api_segment_controller.ex
@@ -98,7 +98,7 @@ defmodule KeilaWeb.ApiSegmentController do
     Contacts.delete_project_segments(project_id(conn), [id])
 
     conn
-    |> put_status(204)
+    |> send_resp(:no_content, "")
   end
 
   defp project_id(conn), do: conn.assigns.current_project.id