added yoonjung choi to website #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 24, 2023 14:05
joyliu-q
requested changes
Sep 27, 2023
src/json/members/choiyoon.json
Outdated
| "hometown": "Hong Kong", | ||
| "team": "Penn Clubs", | ||
| "roles": ["Business Developer"], | ||
| "photo": "https://media.licdn.com/dms/image/D5603AQHYyI1WDPwFvw/profile-displayphoto-shrink_400_400/0/1678278503421?e=1701302400&v=beta&t=rGoJZl7lZCxJwDz3xJPJnMk4IbHkzY85eyXdMnB1mZ8", |
There was a problem hiding this comment.
It's easy for this type of photo to no longer have a valid URL after a certain period of time. Rather than right clicking on LinkedIn profile to copy image URL, I would recommend using a hosting site like Imgur.
src/json/members/choiyoon.json
Outdated
| "linkedin": "https://www.linkedin.com/in/yoonjungchoi05/", | ||
| "website": "", | ||
| "github": "https://github.com/yoonjung27", | ||
| "semester_joined": "2023F", |
There was a problem hiding this comment.
Rather than saying 2023F, please reference our guide here on notation: https://www.notion.so/pennlabs/Creating-or-Updating-a-Member-Page-f896d85568b848c594e005708f8cb1a6
joyliu-q
reviewed
Sep 27, 2023
src/json/members/choiyoon.json
Outdated
| "alumnus": false, | ||
| "graduation_year": 2027, | ||
| "job": null | ||
| } |
There was a problem hiding this comment.
Also, nit: let's add a new line here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.