Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot API v8.0 #408

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Bot API v8.0 #408

wants to merge 13 commits into from

Conversation

anfanik
Copy link
Collaborator

@anfanik anfanik commented Dec 8, 2024

This pull request implements the Bot API 8.0 update

@anfanik anfanik mentioned this pull request Dec 8, 2024
@anfanik
Copy link
Collaborator Author

anfanik commented Dec 9, 2024

@pengrad @MartelliEnrico 👀

Copy link
Owner

@pengrad pengrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay.

This delegated property approach won't work good for Java users as it breaks method chaining.
So we need to write additional fun for every property like in CreateInvoiceLink.

Wouldn't be simpler to just use one line functions?
fun providerToken(providerToken: String) = add("provider_token", providerToken)

@anfanik
Copy link
Collaborator Author

anfanik commented Dec 21, 2024

You're right, chaining in Java is broken 🤔
I thought deligates will simplify model classes and remove a lot of boilerplate code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants