Changed API from bot-centered to method-centered #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Moved execute method from TelegramBot to BaseRequest • Moved DeleteMyCommands.java from model to request • Added BaseRequest.api member for execute method • Added api argument to all constructors and static generator functions and passed them down to BaseRequest. • Added wrapper functions for all requests in TelegramBot. • Fixed tests to use new API. NOTE: LogOutCloseTest.java is inherently broken and has to be fixed. • Deprecated the entire SetStickerSetThumb class, instead of one of the compilers. • Fixed API usage in sample to match the new API. • Added lambda syntax to execute method
|
@pengrad review? :) |
s0m31-hub
reviewed
Jun 4, 2024
There was a problem hiding this comment.
Cloned your branch.
I prefer the way we have stuff in current version. Or at least would need some layer to have both method-based and request-based execution.
Method-based control will be cool in small and easy bots that are easy to code. It is always easier to call a method rather than 1) creating request. 2) setting it up. 3) passing as a parameter. But let's take a look at its main disadvantages now:
- methods are not as configurable as classes. I didn't find how you want people to attach keyboards to their messages. You either need 100 overloads or think of something crazy
- Java is famous with its class structure. Getting rid of it is just making it less Java
- No backward compatibility. All classes now wants TelegramBotClient in constructor, which makes it impossible to update old projects to newer version of bot api without complete rewrites.
- I love integrating IoC to my projects (who doesn't? Spring is used everywhere). And I used to have lists of requests to be executed, which another component borrowed and nailed the job. Now it is impossible, as everything have to be methods. Would either need a lot of reflection tweaks or create a ton of code just to achieve same results.
Overall, choosing small and very easy bots over big ones is totally not what I wanna see. Maybe if that was in parallel to classes - changes would be okay. But not in the current way you made it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #164