AMM RPC endpoints for UI integration #220

RustNinja · 2023-04-19T20:47:20Z

PR related to #217
and pendulum-chain/Zenlink-DEX-Module#1

PR based on top of this PR(it is already merged)

expose zenlink rpc endpoints from pendulum/amplitude/foucoco runtime

Co-authored-by: Marcel Ebert <[email protected]>

add farming rpc api for foucoco

create_full_spacewalk_foucoco -> create_full_foucoco create_full_spacewalk -> create_full_amplitude create_full -> create_full_pendulum

Co-authored-by: Marcel Ebert <[email protected]>

start_node_impl() -> start_node_impl_pendulum() start_node_impl_spacewalk_foucoco() -> start_node_impl_foucoco() start_node_impl_spacewalk_amplitude() -> start_node_impl_amplitude()

… into 207-implement-lp-rewards-on-amm

ebma · 2023-04-20T07:50:09Z

@TorstenStueber in case you are wondering why we need yet another fork, I looked into this with Nikita and we tried to patch it again but it did not work unfortunately. Forking was easiest, and we can get rid of that fork again, once we complete #219 because Zenlink has more up-to-date jsonrpsee dependencies on their polkadot-v0.9.38 branch.

207 implement lp rewards on amm (#208) * add bifrost-farming and bifrost-farming-rpc-runtime-api dependency * introduce T::CurrencyId to bifrost farming pallet * add farming runtime rpc to foucoco * Update runtime/foucoco/src/lib.rs * fix build in foucoco runtime with FoucocoTreasuryAccount * add patch for git and crates io * update pr according to request changes in PR #208 * Add farming rpc api intou pendulum node for foucoco runtime (#216) add farming rpc api for foucoco * move PoolId type declaration to runtime common * renaming create_full_spacewalk_foucoco -> create_full_foucoco create_full_spacewalk -> create_full_amplitude create_full -> create_full_pendulum * replace "introduce-abstraction-for-currency-id" to "polkadot-v0.9.37" * Update runtime/common/src/lib.rs * renaming start_node_impl() -> start_node_impl_pendulum() start_node_impl_spacewalk_foucoco() -> start_node_impl_foucoco() start_node_impl_spacewalk_amplitude() -> start_node_impl_amplitude() --------- Co-authored-by: Marcel Ebert <[email protected]>

C::Api: ZenlinkProtocolRuntimeApi<Block, AccountId, AssetId>,

node/src/rpc.rs

ebma

As I said in the comments I would not introduce a separate development config now. At least not as part of this PR. If this is needed then let's do that somewhere else, after discussing it

node/src/rpc.rs

node/src/command.rs

RustNinja · 2023-04-21T15:05:18Z

As I said in the comments I would not introduce a separate development config now. At least not as part of this PR. If this is needed then let's do that somewhere else, after discussing it

@ebma
it is not possible to NOT introduce new function for development because of the different implementation between pendulum runtime and development runtime.
Now to expose Zenlink RPC endpoints we need to add new trait bound
C::Api: ZenlinkProtocolRuntimeApi<Block, AccountId, AssetId>,

it means that it not possible anymore to use the same function as for pendulum and development runtime.

ebma

Okay I see. I was not fully aware what's added to the development runtime. AFAIK we don't really use it. But it's probably the right step to also add other functions for that, now that we basically split everything up per network anyways.

The rest LGTM.

TorstenStueber · 2023-04-24T07:41:14Z

@TorstenStueber in case you are wondering why we need yet another fork, I looked into this with Nikita and we tried to patch it again but it did not work unfortunately. Forking was easiest, and we can get rid of that fork again, once we complete #219 because Zenlink has more up-to-date jsonrpsee dependencies on their polkadot-v0.9.38 branch.

I am a little confused about the issues and PRs and how they are linked. This PR here is linked with an issue (#217), which itself is linked to another PR (#218), then you mention issue #219.

Is there a way to clean up the PR <-> issue structure?

RustNinja · 2023-04-24T10:56:32Z

@TorstenStueber in case you are wondering why we need yet another fork, I looked into this with Nikita and we tried to patch it again but it did not work unfortunately. Forking was easiest, and we can get rid of that fork again, once we complete #219 because Zenlink has more up-to-date jsonrpsee dependencies on their polkadot-v0.9.38 branch.

I am a little confused about the issues and PRs and how they are linked. This PR here is linked with an issue (#217), which itself is linked to another PR (#218), then you mention issue #219.

Is there a way to clean up the PR <-> issue structure?

@TorstenStueber
Done

TorstenStueber · 2023-04-26T15:07:50Z

node/src/service.rs

@@ -766,6 +771,192 @@ where
 	Ok((task_manager, client))
 }

+/// Start a node with the given parachain `Configuration` and relay chain `Configuration`.


@RustNinja where is all of this code coming from? Is the code duplication now even getting worse?

If it is just duplicated code, then fine. If there are any crucial changes to the duplicated code here, can you point them out?

RustNinja and others added 16 commits April 13, 2023 20:13

add bifrost-farming and bifrost-farming-rpc-runtime-api dependency

6d186af

introduce T::CurrencyId to bifrost farming pallet

9ce1d0e

add farming runtime rpc to foucoco

a003da2

Update runtime/foucoco/src/lib.rs

657c0ec

Co-authored-by: Marcel Ebert <[email protected]>

fix build in foucoco runtime with FoucocoTreasuryAccount

4581c84

add patch for git and crates io

4b27234

update pr according to request changes in PR

c27e3a6

#208

Add farming rpc api intou pendulum node for foucoco runtime (#216)

9d84f1e

add farming rpc api for foucoco

move PoolId type declaration to runtime common

3ceab7e

renaming

d4e1b70

create_full_spacewalk_foucoco -> create_full_foucoco create_full_spacewalk -> create_full_amplitude create_full -> create_full_pendulum

replace "introduce-abstraction-for-currency-id" to "polkadot-v0.9.37"

bcdaa02

Update runtime/common/src/lib.rs

a527b11

Co-authored-by: Marcel Ebert <[email protected]>

renaming

5cfdcac

start_node_impl() -> start_node_impl_pendulum() start_node_impl_spacewalk_foucoco() -> start_node_impl_foucoco() start_node_impl_spacewalk_amplitude() -> start_node_impl_amplitude()

Merge remote-tracking branch 'origin/207-implement-lp-rewards-on-amm'…

2d3442c

… into 207-implement-lp-rewards-on-amm

Merge branch '207-implement-lp-rewards-on-amm' into zenlink-rpc

a142345

expose zenlink runtime rpc endpoints in pendulum-node

502b086

RustNinja requested review from b-yap, ebma and TorstenStueber April 19, 2023 20:47

RustNinja mentioned this pull request Apr 21, 2023

217 add zenlink rpc to pendulum/amplitude/foucoco node #218

Closed

RustNinja and others added 4 commits April 21, 2023 13:33

Merge remote-tracking branch 'origin/main' into zenlink-rpc

354cbb7

remove duplicates in foucoco cargo toml

4d0066f

remove duplication

428df22

C::Api: ZenlinkProtocolRuntimeApi<Block, AccountId, AssetId>,

ebma reviewed Apr 21, 2023

View reviewed changes

node/src/rpc.rs Outdated Show resolved Hide resolved

ebma requested changes Apr 21, 2023

View reviewed changes

node/src/rpc.rs Show resolved Hide resolved

node/src/command.rs Show resolved Hide resolved

remove unnecessary clone for TransactionPayment instance

c371e8a

RustNinja requested a review from ebma April 21, 2023 14:23

ebma approved these changes Apr 21, 2023

View reviewed changes

RustNinja linked an issue Apr 24, 2023 that may be closed by this pull request

Add Zenlink RPC to pendulum node #217

Closed

RustNinja merged commit ebd6e55 into main Apr 24, 2023

RustNinja deleted the zenlink-rpc branch April 24, 2023 17:24

TorstenStueber reviewed Apr 26, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AMM RPC endpoints for UI integration #220

AMM RPC endpoints for UI integration #220

RustNinja commented Apr 19, 2023 •

edited

Loading

ebma commented Apr 20, 2023

ebma left a comment

RustNinja commented Apr 21, 2023

ebma left a comment

TorstenStueber commented Apr 24, 2023

RustNinja commented Apr 24, 2023

TorstenStueber Apr 26, 2023

AMM RPC endpoints for UI integration #220

AMM RPC endpoints for UI integration #220

Conversation

RustNinja commented Apr 19, 2023 • edited Loading

ebma commented Apr 20, 2023

ebma left a comment

Choose a reason for hiding this comment

RustNinja commented Apr 21, 2023

ebma left a comment

Choose a reason for hiding this comment

TorstenStueber commented Apr 24, 2023

RustNinja commented Apr 24, 2023

TorstenStueber Apr 26, 2023

Choose a reason for hiding this comment

RustNinja commented Apr 19, 2023 •

edited

Loading