Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom handling for argentinian blue dollar #34

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

ebma
Copy link
Member

@ebma ebma commented Oct 8, 2024

  • Creates a new directory custom that holds the implementation of the custom handler for the AMPE and ARS-USD (blue dollar) rate
  • Adds an implementation for the binance API. Binance only rate limits per IP, and many public endpoints don't even require an API key so the implementation of the Binance client does not allow passing that. The endpoint for the price is documented here.
  • To make sure that the FIAT:ARS-USD AssetSpecifier will receive a quotation from the custom handler (blue dollar) and not a fiat price from polygon, the supported custom assets are filtered from the list before passing it to the fiat and crypto handler in dia-batching-server/src/api/mod.rs

Closes #32.

@ebma ebma linked an issue Oct 8, 2024 that may be closed by this pull request
@ebma ebma requested a review from a team October 8, 2024 14:14
Copy link

@gianfra-t gianfra-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

@TorstenStueber TorstenStueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ebma ebma merged commit 62d3dac into master Oct 9, 2024
1 check passed
@ebma ebma deleted the 32-add-custom-handling-for-argentinian-blue-dollar branch October 9, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom handling for argentinian blue dollar
3 participants