convArtiToPromNumber use case #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regular expression `pattNumber` did not recognise the word `1000GB`.
|
peimanja
approved these changes
Nov 7, 2024
KacperPerschke
added a commit
to KacperPerschke/artifactory_exporter
that referenced
this pull request
Nov 8, 2024
A Peiman wrote in peimanja#150 (review)
I have attempted to do this in #151. |
peimanja
added a commit
that referenced
this pull request
Dec 6, 2024
A Peiman wrote in #150 (review) Co-authored-by: Peiman Jafari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular expression
pattNumberdid not recognise the word1000GB.This was detected when test running the application with the ‘#149’ commits applied.
The solution is not fully immune to passing errors. For example, it will let through the
1000,999KBtext. But I do not want to complicate the regualr expressionpattNumber.Please address this very much before #149.