refactor: parallel processing #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr15k
changed the title
benjam-es
suggested changes
Jan 17, 2025
chr15k
changed the title
Hey @benjam-es, after adding more tests, I noticed that performance worsens with large datasets (e.g., if $text was 10,000+ lines), as it spawns n processes. I then tried chunking, which helped but was still slower than the main branch for this size. Given this, I actually don’t think it’s worth committing since the change isn't significant enough an improvement and adds extra complexity. I think if we can improve the first-run speed we'll need a better/different approach. I'll close this PR, thanks for looking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
Implemented parallel processing in the Aspell Spellchecker class, resulting in a 40% performance improvement on the first (non-cached) run.
Testing
To more easily test this, manually comment out caching in the Aspell class, run Pest while switching between main branch and this branch.
Test notes
Main branch with caching turned off
This branch with caching turned off