Added words from Laravel Framework and Horizon

[andrey-helldar]

What:

• Bug Fix
• New Feature

Description:

Laravel Framework

• apa (Str::apa())
• doesnt (doesntExist method of Builder or Collection)
• dont ($dontReport) property name or method name from exceptions
• incrementing (models)
• ulid

Laravel Horizon

• cooldown (balanceCooldown)

Base

• oauth
• ttl

[calvinludwig]

I believe that instead of adding contractions, like "doesnt" or "dont", to the whitelist, it should just not report it as a misspelling.

We can do this by matching the checked word to each Aspell suggestions; if the contraction's apostrophe is the only difference, ignore it as a misspelling.

What do you guys think @nunomaduro and @c0nst4ntin ?

[julio-cavallari]

I believe that instead of adding contractions, like "doesnt" or "dont", to the whitelist, it should just not report it as a misspelling.

We can do this by matching the checked word to each Aspell suggestions; if the contraction's apostrophe is the only difference, ignore it as a misspelling.

What do you guys think @nunomaduro and @c0nst4ntin ?

I think it's a fair thought, dont or doesnt in a class, method, property, function, etc., really shouldn't be a misspelling

But when it comes to descriptive texts like doc blocks, texts in templates, etc., this is a misspelling, 'cause dont theoretically doesn't exist and shouldn't be used to document something in the code, or be shown in the content of a website/system/app.

So I don't know if we should really ignore it whenever a case like this is suggested as misspelling.

[andrey-helldar]

Or, if possible, add a check for the type that if it is the name of a property, method, function, class, or other control value, then don't consider it an error, but if the word occurs in text, such as a docblock, then return an error.

But how correct this will be outside Laravel is a big question.

[c0nst4ntin]

@andrey-helldar @julio-cavallari I agree, in theory we should not mark words like "dont" as a spelling mistake in code names. But at the same time, we should detect it in doc blocks.

The only question is, how can we achieve this? We would need to keep context about what type of text we are checking.

However, this is a more challenging topic. Maybe you can open an issue for this and we can challenge this in a new pull request.

For now maybe take them out of this pull request. The other words look fine to me 👍🏼

Will mark this as a draft. Please mark it back as "ready for review" once you changed it.

[andrey-helldar]

@c0nst4ntin, @julio-cavallari, I agree.

I cleaned up the words and also created an issue: #120