-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PEAUTY-157] /designer/signup-detail 페이지 컴포넌트 분리 및 API 연결 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myoungjinGo-FE
approved these changes
Dec 8, 2024
myoungjinGo-FE
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR에 대한 자세한설명 좋아요 👍 이해완
ZUITOPIA
changed the title
[PEAUTY-157] TitleContentInput 컴포넌트 생성
[PEAUTY-157] /designer/signup-detail 페이지 컴포넌트 분리 및 API 연결
Dec 8, 2024
ZUITOPIA
changed the title
[PEAUTY-157] /designer/signup-detail 페이지 컴포넌트 분리 및 API 연결
[PEAUTY-157] /designer/signup-detail 페이지 컴포넌트 분리
Dec 9, 2024
ZUITOPIA
changed the title
[PEAUTY-157] /designer/signup-detail 페이지 컴포넌트 분리
[PEAUTY-157] /designer/signup-detail 페이지 컴포넌트 분리 및 API 연결
Dec 9, 2024
Sieonn
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
충돌 해결하고 push 한 다음 merge해주세요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 작업 내용
작업 내용 1
제목, 내용 input이 연달아서 필요할 때 사용할 TitleContentInput 컴포넌트 생성 후 분리
사용 예시
작업 내용 2
ShopInfoInputSection 컴포넌트 생성 후 분리
작업 내용 3
CustomInput 컴포넌트 수정 (extraText를 props로 전달하여 아래와 같이 사용 가능)
(전)
변경 전 코드
(후)
사용 예시 (변경 후 코드)
작업 내용 4
자격증 입력받는 부분 CertificateInputSection 컴포넌트로 분리
작업 내용 5
결제 방식 중복선택 가능하므로 radio button에서 multi select button으로 변경
(전)
(후)
작업 내용 6
react-daum-postcode 사용하여 우편번호 검색 서비스 띄우기
이 과정에서 GNB.styles.ts의 Nav의 z-index를 1000에서 ${theme.zIndex.gnb}; 로,
CustomModal.styles.ts의 ModalBackdrop의 z-index를 1000 에서 ${theme.zIndex.bottomSheet}; 로 수정하였습니다
🧠 PR 체크
완료하셨다면 띄어쓰기 대신 [] 사이에 소문자 x로 표시해주세요.