Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PEAUTY-133] 고객 관점 요청서 #67

Merged
merged 16 commits into from
Dec 11, 2024
Merged

[PEAUTY-133] 고객 관점 요청서 #67

merged 16 commits into from
Dec 11, 2024

Conversation

ZUITOPIA
Copy link
Contributor

@ZUITOPIA ZUITOPIA commented Dec 6, 2024

💻 작업 내용

어떤 기능을 개발했나요?

  • 미용할 반려견 선택 UI

📷 이미지 첨부

더 자세한 설명을 위해 첨부하실 이미지가 있다면 첨부해주세요.

미용할 반려견 선택 UI 전 후 비교


image
image

🧠 PR 체크

완료하셨다면 띄어쓰기 대신 [] 사이에 소문자 x로 표시해주세요.

  • 담당자와 리뷰어를 설정했어요.
  • label을 설정했어요.

Copy link

github-actions bot commented Dec 6, 2024

💄 Storybook: https://674ed57ea9f6bd66479b5aba-schqacuivp.chromatic.com/
🕖 Update: 2024년 12월 07일 17시 10분 38초


const handleChoosePet = (pet: (typeof dummyPet)[number]) => {
setSelectedPetId(pet.puppyId);
console.log("Clicked Pet:", pet);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 주희님
로그는

Copy link
Contributor

@jissssu jissssu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완전 코드도 깔끔하게 UI 해주신 것 같아요!

Copy link
Contributor

@jissssu jissssu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컴플릭트 해결후 합쳐주시면 될 것 같습니다!

@myoungjinGo-FE myoungjinGo-FE changed the base branch from sprint/1 to develop December 10, 2024 04:34
@Sieonn Sieonn force-pushed the feature/PEAUTY-133 branch from 9e11dca to 02771b1 Compare December 10, 2024 08:48
@Sieonn Sieonn self-assigned this Dec 11, 2024
Comment on lines 23 to 26
export default function PetEdit() {
const dogBreeds = ["말티즈", "푸들", "말티푸", "비숑", "시츄"]; // 더미 데이터 (나중에 api로 get 해올 것)
const dummyDogBreeds = ["말티즈", "푸들", "말티푸", "비숑", "시츄"]; // 더미 데이터 (나중에 api로 get 해올 것)
const [selectedBreed, setSelectedBreed] = useState<string>("");

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분 아마 이넘타입이라 그거에 맞게 넣기만 하면 될 것 같습니다!

Comment on lines +14 to +21
import { colors } from "../../../../../../style/color";
export interface DropBoxProps {
label?: string; // Optional label text
placeholder: string; // Default text for the dropdown
options: string[]; // List of options (e.g., "Maltese", "Poodle")
onSelect: (value: string) => void; // Callback for when an option is selected
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에 주석은 지워주세요!

@jissssu jissssu merged commit 8ed238f into develop Dec 11, 2024
2 checks passed
@jissssu jissssu deleted the feature/PEAUTY-133 branch December 11, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants