-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flake for new mailcap dependency #1685
Conversation
You are right, I did not consider the CI status when pushing this las PR. |
@pazz we could leave the nix stuff out of the required checks but I would prefer if we can see in a pr that it gets broken. If nobody can/wants to figure out how to fix it they can at least ping me. |
The problem about the current situation is, that we can not run all our test cases on a default ci machine (ubuntu) because the python gpg module is not installable (#1630). We only run 289 test cases on the ubuntu runner vs 344 in the https://github.com/pazz/alot/actions/runs/12234986811/job/34125317235#step:10:346 https://github.com/pazz/alot/actions/runs/12234986810/job/34125316256#step:4:1283 |
You are right. let's do it! |
@pazz I think the first step is the settings in the alot project page here on github (and I think only you can edit that). You would need to create a protection rule for the master branch and then define who can push to it or what is required from a merge request. |
If you move a repo it will keep all metadata (issues, prs, settings...). The repo https://github.com/notmuch/notmuch is just a mirror and they don't accept PRs through github. If they do not want an active github project in their org you can start an alot org and move it there. Others are doing it like this: |
Do you think it'd be a good idea to do this?
Quoting Lucas Hoffmann ***@***.***) at 2024-12-11 09:30:07
… If you move a repo it will keep all metadata (issues, prs, settings...).
The repo https://github.com/notmuch/notmuch is just a mirror and they don't
accept PRs through github. If they do not want an active github project in
their org you can start an alot org and move it there.
Others are doing it like this:
• https://github.com/astroidmail
• https://github.com/purebred-mua/
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.*Message ID: <pazz/alot/pull/
***@***.***>
|
I don't know if it is a good idea. That depends on what your goals with moving to the notmuch org would be?
|
This should fix the nix build which is broken due to #1684.
The standard-mailcap package is not yet available in nixpkgs so this still breaks for python 3.13 on nix but at least the dependency parsing works again and the derivation can be used with python <=3.12.
@pazz what do you think about requiring green CI for pull requests? I would quite like that.