Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flake for new mailcap dependency #1685

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Update flake for new mailcap dependency #1685

merged 1 commit into from
Dec 9, 2024

Conversation

lucc
Copy link
Collaborator

@lucc lucc commented Dec 8, 2024

This should fix the nix build which is broken due to #1684.

The standard-mailcap package is not yet available in nixpkgs so this still breaks for python 3.13 on nix but at least the dependency parsing works again and the derivation can be used with python <=3.12.


@pazz what do you think about requiring green CI for pull requests? I would quite like that.

@lucc lucc added deployment dependencies Pull requests that update a dependency file labels Dec 8, 2024
@pazz pazz merged commit e0b71b8 into master Dec 9, 2024
24 checks passed
@pazz
Copy link
Owner

pazz commented Dec 9, 2024

You are right, I did not consider the CI status when pushing this las PR.
In principle I think it is a good idea to require a green status, yes.
About flake/nix in particular I worry though that you are among the only ones who care and could reasonably fix this, and perhaps requiring such fixes is creating unecessary hurdles?

@lucc lucc deleted the nix-mailcap branch December 9, 2024 15:55
@lucc
Copy link
Collaborator Author

lucc commented Dec 9, 2024

@pazz we could leave the nix stuff out of the required checks but I would prefer if we can see in a pr that it gets broken. If nobody can/wants to figure out how to fix it they can at least ping me.

@lucc
Copy link
Collaborator Author

lucc commented Dec 9, 2024

The problem about the current situation is, that we can not run all our test cases on a default ci machine (ubuntu) because the python gpg module is not installable (#1630). We only run 289 test cases on the ubuntu runner vs 344 in the nix build

https://github.com/pazz/alot/actions/runs/12234986811/job/34125317235#step:10:346

https://github.com/pazz/alot/actions/runs/12234986810/job/34125316256#step:4:1283

@pazz
Copy link
Owner

pazz commented Dec 9, 2024

You are right. let's do it!

@lucc
Copy link
Collaborator Author

lucc commented Dec 10, 2024

@pazz I think the first step is the settings in the alot project page here on github (and I think only you can edit that).

You would need to create a protection rule for the master branch and then define who can push to it or what is required from a merge request.

@pazz
Copy link
Owner

pazz commented Dec 11, 2024

I think I did this now

2024-12-11T08:56:01,883875071+00:00

Tangentially related: I would really like to move this repo under the notmuch org and give you full access in the long run.
Not sure if this would preserve all issues/PRs.. thoughts?

@lucc
Copy link
Collaborator Author

lucc commented Dec 11, 2024

If you move a repo it will keep all metadata (issues, prs, settings...).

The repo https://github.com/notmuch/notmuch is just a mirror and they don't accept PRs through github. If they do not want an active github project in their org you can start an alot org and move it there.

Others are doing it like this:

@pazz
Copy link
Owner

pazz commented Dec 11, 2024 via email

@lucc
Copy link
Collaborator Author

lucc commented Dec 11, 2024

I don't know if it is a good idea. That depends on what your goals with moving to the notmuch org would be?

  • more visibility for alot? --> might not change with an alot-org
  • shared responsibility? --> can be done with an alot-org (might also be doable in your repo right now)
    • we could add a CODEOWNERS file (you could also put me down as the code owner of the nix code)
  • clear distinction between alot team and other contributors?
    • easier in alot-org than notmuch-org I think, in notmuch-org the alot team and the notmuch team might get mixed up by outsiders --> outsiders might not know who to talk to or who is responsible for what (I assume that the alot team and the notmuch team are currently distinct sets of people)
    • CODEOWNERS again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants