fix(plugin-multi-tenant): fixed hardcoded user tenants field #10782
+80
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarrodMFlesch
requested changes
Jan 25, 2025
There was a problem hiding this comment.
I think the intent is correct with passing in field names for the tenants array. However, the field names should be specific - you should not be required to use the same name as the tenants collection or the tenant field name.
You will also need to search for places where we are doing tenants.tenant where queries and thread these two new name properties to those locations.
Let me know if you need any help with this!
packages/plugin-multi-tenant/src/fields/tenantsArrayField/index.ts
Outdated
Show resolved
Hide resolved
packages/plugin-multi-tenant/src/fields/tenantsArrayField/index.ts
Outdated
Show resolved
Hide resolved
packages/plugin-multi-tenant/src/fields/tenantsArrayField/index.ts
Outdated
Show resolved
Hide resolved
robclancy
force-pushed
the
main
branch
2 times, most recently
from
faf8186 to
3642f63
Compare
|
I haven't directly tested anything yet, I will be trying out this on our cms soon. |
JarrodMFlesch
requested changes
Jan 28, 2025
### What? When using custom slugs and field names the tenancy field added to the users would still attempt to use tenants and fail. ### Why? The tenant/tenancy are hardcoded in `tenantsArrayField()` ### How? Added the same args that are used in `tenantsField()` for the field names and relation.
JarrodMFlesch
approved these changes
Jan 29, 2025
|
🚀 This is included in version v3.21.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When using custom slugs and field names the tenancy field added to the users would still attempt to use
tenantsand fail.Why?
The tenant/tenancy are hardcoded in
tenantsArrayField()How?
Added the same args that are used in
tenantsField()for the field names and relation.