chore(templates): make TypeScript strict in website template #10587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GermanJablo
commented
Jan 15, 2025
| @@ -125,7 +125,7 @@ export const Pages: CollectionConfig<'pages'> = { | |||
| hooks: { | |||
| afterChange: [revalidatePage], | |||
| beforeChange: [populatePublishedAt], | |||
| beforeDelete: [revalidateDelete], | |||
| afterDelete: [revalidateDelete], | |||
There was a problem hiding this comment.
@paulpopus is this correct? beforeDelete doesn't have access to doc so ts complains. I don't know if it was working properly before this.
There was a problem hiding this comment.
Yeah I think this fine if you've tested it works
GermanJablo
changed the title
paulpopus
reviewed
Jan 15, 2025
| @@ -125,7 +125,7 @@ export const Pages: CollectionConfig<'pages'> = { | |||
| hooks: { | |||
| afterChange: [revalidatePage], | |||
| beforeChange: [populatePublishedAt], | |||
| beforeDelete: [revalidateDelete], | |||
| afterDelete: [revalidateDelete], | |||
There was a problem hiding this comment.
Yeah I think this fine if you've tested it works
| export async function generateMetadata({ params: paramsPromise }): Promise<Metadata> { | ||
| const { slug = 'home' } = await paramsPromise | ||
| export async function generateMetadata({ params }: Args): Promise<Metadata> { | ||
| const { slug = 'home' } = await params |
There was a problem hiding this comment.
Small nitpick here, but we should consistently rename params to paramsPromise. Since it's a paradigm shift, it's better they understand this is a promise you need to await, for those learning nextjs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating pnpm-lock was necessary due to #10398