feat: add endpoints about ThreeDSecureRequest object. #63
+99
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -264,7 +268,7 @@ namespace Payjp { | |||
| total_platform_fee?: number, | |||
| tenant?: string | null, | |||
| product?: any, | |||
| three_d_secure_status: string | null, | |||
| three_d_secure_status: ThreeDSecureStatus, | |||
There was a problem hiding this comment.
three_d_secure_statusプロパティは現状chargeとcardにあります。cardも合わせてもらえますか？
There was a problem hiding this comment.
fbee108
card 付けるの忘れてました。ありがとうございます。
修正しました✍
| @@ -11,6 +11,7 @@ import Transfers from './transfer'; | |||
| import Statements from './statement'; | |||
| import Terms from "./term"; | |||
| import Balances from "./balance"; | |||
| import ThreeDSecureRequests from "./threeDSecureRequest"; | |||
There was a problem hiding this comment.
クラス名に合わせてファイルもthreeDSecureRequests(末尾のsつける)がいいんじゃないですかね。
本来は他のリソースもそうすべきに見える
There was a problem hiding this comment.
振る舞いに変更は無いので一旦このPRではこのままにしておきたいです。
別 PR で対処させてください。
test/threeDSecureRequest.spec.js
Outdated
| const query = { | ||
| resource_id: 'car_xxxxxxxxxxxxxxxxxxxxxxxxx' | ||
| }; | ||
| return payjp.three_d_secure_requests.create(query).then(([_method, _endpoint]) => { |
There was a problem hiding this comment.
queryのassertionも足したいですね
natsuki-yamanaka
approved these changes
Nov 12, 2024
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
add endpoints about ThreeDSecureRequest object.