feat: add term and balance. #52
Merged
+173
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niheeeee
reviewed
Apr 1, 2024
niheeeee
approved these changes
Apr 1, 2024
niheeeee
reviewed
Apr 9, 2024
src/index.ts
Outdated
| type?: "sales" | "service_fee" | "transfer_fee", | ||
| } | ||
|
|
||
| export interface TermListOptions extends ListOptions { |
There was a problem hiding this comment.
[ask]
ListOptionsを継承した場合に、Termオブジェクトだとcreatedが無いので since/until が対象無いのは明確にはしない方針でしたっけ？
動作は特に問題ないはず。
There was a problem hiding this comment.
Pagination Option を追加してみました。
以前口頭で話したと思いますが、この作りは治安を悪くしそうで少し不安です。
現状すぐに対応できる案として、ネーミングで治安維持を図ろうと思いますが、他にいい案あれば教えてほしいです。
There was a problem hiding this comment.
Pagination と CreatedRange に分離するというのは、既に他でもある概念なので問題ないと思います。
今後さらに追加や分離となりそうな場合には考え直しが必要そう。
version 上げました。 |
niheeeee
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Changes due to the addition of the Term and Balance objects.
Changes
Add term object
https://pay.jp/docs/api/#term%E9%9B%86%E8%A8%88%E5%8C%BA%E9%96%93
Add balance object
https://pay.jp/docs/api/#balance-%E6%AE%8B%E9%AB%98
Add term and balance id in Statement balance object
https://pay.jp/docs/api/#statement%E3%82%AA%E3%83%96%E3%82%B8%E3%82%A7%E3%82%AF%E3%83%88
Add term id in charge object https://pay.jp/docs/api/#charge%E3%82%AA%E3%83%96%E3%82%B8%E3%82%A7%E3%82%AF%E3%83%88