Keep delete logbook to allow recovery

sci-log-db/src/__tests__/acceptance/logbook.controller.acceptance.ts

@@ -397,6 +397,14 @@ describe('Logbook', function (this: Suite) {
       .expect(404);
   });
 
+  it('delete snippet by id with token should return 204', async () => {
+    await client
+      .delete(`/logbooks/${logbookSnippetId}`)
+      .set('Authorization', 'Bearer ' + adminToken)
+      .set('Content-Type', 'application/json')
+      .expect(204);
+  });
+
   it('restore snippet by id without token should return 401', async () => {
     await client
       .patch(`/logbooks/${logbookSnippetId}/restore`)
@@ -410,6 +418,15 @@ describe('Logbook', function (this: Suite) {
       .set('Authorization', 'Bearer ' + token)
       .set('Content-Type', 'application/json')
       .expect(204);
+    await client
+      .get(`/logbooks/${logbookSnippetId}`)
+      .set('Authorization', 'Bearer ' + token)
+      .set('Content-Type', 'application/json')
+      .expect(200)
+      .then(result => expect(result.body.id).to.eql(logbookSnippetId))
+      .catch(err => {
+        throw err;
+      });
   });
 
   it('post a logbook with authentication and should create default ACLS from parent', async () => {

sci-log-db/src/controllers/logbook.controller.ts

@@ -218,7 +218,7 @@ export class LogbookController {
     },
   })
   async deleteById(@param.path.string('id') id: string): Promise<void> {
-    await this.logbookRepository.deleteById(id, {
+    await this.logbookRepository.deleteByIdWithHistory(id, {
       currentUser: this.user,
     });
   }