sonar fixes

paulgessinger · Jan 30, 2025 · aa431d2 · aa431d2
1 parent fa59d56
commit aa431d2
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/Core/include/Acts/EventData/TrackProxy.hpp b/Core/include/Acts/EventData/TrackProxy.hpp
@@ -124,15 +124,15 @@ class TrackProxy {
   /// @note Only available if the track proxy is read-only
   /// @param other the other track proxy
   explicit TrackProxy(const MutableTrackProxy& other)
-    requires(ReadOnly)
+    requires ReadOnly
       : m_container{other.m_container}, m_index{other.m_index} {}
 
   /// Copy assignment operator from mutable track proxy
   /// @note Only available if the track proxy is read-only
   /// @param other the other track proxy
   /// @return reference to this track proxy
   TrackProxy& operator=(const MutableTrackProxy& other)
-    requires(ReadOnly)
+    requires ReadOnly
   {
     m_container = other.m_container;
     m_index = other.m_index;

diff --git a/Core/include/Acts/EventData/TrackStateProxy.hpp b/Core/include/Acts/EventData/TrackStateProxy.hpp
@@ -227,15 +227,15 @@ class TrackStateProxy {
   /// @note Only available if the track state proxy is read-only
   /// @param other The other TrackStateProxy to construct from
   explicit TrackStateProxy(const TrackStateProxy<Trajectory, M, false>& other)
-    requires(ReadOnly)
+    requires ReadOnly
       : m_traj{other.m_traj}, m_istate{other.m_istate} {}
 
   /// Assignment operator to from mutable @c TrackStateProxy
   /// @param other The other TrackStateProxy to assign from
   /// @note Only available if the track state proxy is read-only
   /// @return Reference to this TrackStateProxy
   TrackStateProxy& operator=(const TrackStateProxy<Trajectory, M, false>& other)
-    requires(ReadOnly)
+    requires ReadOnly
   {
     m_traj = other.m_traj;
     m_istate = other.m_istate;

diff --git a/Examples/Algorithms/TrackFinding/src/TrackFindingAlgorithm.cpp b/Examples/Algorithms/TrackFinding/src/TrackFindingAlgorithm.cpp
@@ -286,7 +286,7 @@ TrackFindingAlgorithm::TrackFindingAlgorithm(Config config,
   if (m_cfg.trackSelectorCfg.has_value()) {
     m_trackSelector = std::visit(
         [](const auto& cfg) -> std::optional<Acts::TrackSelector> {
-          return std::optional<Acts::TrackSelector>(Acts::TrackSelector(cfg));
+          return Acts::TrackSelector(cfg);
         },
         m_cfg.trackSelectorCfg.value());
   }

diff --git a/Fatras/include/ActsFatras/EventData/Particle.hpp b/Fatras/include/ActsFatras/EventData/Particle.hpp
@@ -168,7 +168,7 @@ class Particle {
   /// Particle hypothesis.
   Acts::ParticleHypothesis hypothesis() const {
     return Acts::ParticleHypothesis(
-        absolutePdg(), mass(),
+        absolutePdg(), static_cast<float>(mass()),
         Acts::AnyCharge{static_cast<float>(absoluteCharge())});
   }
   /// Particl qOverP.