Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add type define for typescript #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add type define for typescript #34

wants to merge 1 commit into from

Conversation

GongT
Copy link

@GongT GongT commented Jun 8, 2017 •
edited
Loading

simple extend "child_process" in @types/node

not modify any code

@tonivj5
Copy link

tonivj5 commented Jul 17, 2017

@patrick-steele-idem can you merge this PR?

@mxbrandi
Copy link

@GongT Any chance you adapt the PR to pass the CI build checks?

@harrysarson
Copy link

@mxbrandi, there CI build checks are failing on the master branch too, it's independent of this pr.

My pr (#32) was meant to fix them but it's not been merged yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GongT @tonivj5 @mxbrandi @harrysarson