-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring for use as an external library #74
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # src/main/java/com/jvmtop/monitor/VMInfo.java
Wow, awesome. I'll have a detailed look within the next days. |
I'll took a first look on your PR. While I'm happy with most of your changes, I've got a few early questions/comments:
|
I pushed my changes. Should I send you another pull request? |
After fixing issue 1. you can open another PR, yes. |
I did it. Is it OK? |
Thanks so much.
|
|
Any news about this pull request? Thanks. Franco |
Please merge this pull request. Thanks |
This is great, @f-lombardo ! |
Any update about this pull request? |
It seems that patric-r isn't an active github user anymore. What do you think about forking the project? |
@f-lombardo yes, you are right. He hasn't been active for a while. I've been pseudo maintaining a fork of it, updating it a features as per my needs here. I've added |
I think it's the only option. Please, go ahead! |
I refactored jvmtop in order to separate logic from presentation. This way, jvmtop could be used both as a library and as a program.