Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev boxed variant #536

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Dev boxed variant #536

wants to merge 13 commits into from

Conversation

jpschorr
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Jan 14, 2025

Conformance comparison report

Base (b056bcf) 8167f03 +/-
% Passing 86.97% 87.15% 0.19%
✅ Passing 5591 5603 12
❌ Failing 838 826 -12
🔶 Ignored 0 0 0
Total Tests 6429 6429 0

Number passing in both: 5591

Number failing in both: 826

Number passing in Base (b056bcf) but now fail: 0

Number failing in Base (b056bcf) but now pass: 12

The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:

Click here to see
  • partiql_tests::eval::ion::primitives::primitives::functions::exists::exists::strict_exists_valid_cases_param_missing_result_true_
  • partiql_tests::eval::ion::primitives::primitives::functions::exists::exists::strict_exists_valid_cases_param_null_result_true_
  • partiql_tests::eval::ion::primitives::primitives::functions::exists::exists::permissive_exists_valid_cases_param_1_result_true_
  • partiql_tests::eval::ion::primitives::primitives::functions::exists::exists::permissive_exists_valid_cases_param_missing_result_true_
  • partiql_tests::eval::ion::query::query::select::from_clause::various_types_in_from_clause::strict_range_over_sexp
  • partiql_tests::eval::ion::query::query::select::projection::project_various_container_types::permissive_project_of_sexp
  • partiql_tests::eval::ion::primitives::primitives::functions::exists::exists::strict_exists_valid_cases_param_result_false_
  • partiql_tests::eval::ion::primitives::primitives::functions::exists::exists::strict_exists_valid_cases_param_1_result_true_
  • partiql_tests::eval::ion::query::query::select::from_clause::various_types_in_from_clause::permissive_range_over_sexp
  • partiql_tests::eval::ion::primitives::primitives::functions::exists::exists::permissive_exists_valid_cases_param_result_false_
  • partiql_tests::eval::ion::query::query::select::projection::project_various_container_types::strict_project_of_sexp
  • partiql_tests::eval::ion::primitives::primitives::functions::exists::exists::permissive_exists_valid_cases_param_null_result_true_

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 81.13855% with 275 lines in your changes missing coverage. Please review.

Project coverage is 81.30%. Comparing base (b056bcf) to head (57b50a9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
extension/partiql-extension-ion/src/boxed_ion.rs 84.67% 86 Missing and 11 partials ⚠️
extension/partiql-extension-ion/src/decode.rs 75.92% 2 Missing and 24 partials ⚠️
...on/partiql-extension-ion-functions/src/read_ion.rs 72.00% 16 Missing and 5 partials ⚠️
...on/partiql-extension-ion-functions/src/scan_ion.rs 73.68% 16 Missing and 4 partials ⚠️
partiql-value/src/datum.rs 81.11% 17 Missing ⚠️
partiql-value/src/value.rs 67.92% 15 Missing and 2 partials ⚠️
partiql-eval/src/plan.rs 72.91% 8 Missing and 5 partials ⚠️
...tension/partiql-extension-ion-functions/src/lib.rs 52.38% 8 Missing and 2 partials ⚠️
partiql-value/src/boxed_variant.rs 77.77% 7 Missing and 1 partial ⚠️
extension/partiql-extension-ion/src/encode.rs 74.07% 4 Missing and 3 partials ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
+ Coverage   81.17%   81.30%   +0.12%     
==========================================
  Files          90       97       +7     
  Lines       19727    20873    +1146     
  Branches    19727    20873    +1146     
==========================================
+ Hits        16014    16971     +957     
- Misses       3293     3431     +138     
- Partials      420      471      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpschorr jpschorr force-pushed the feat-shape-category branch 2 times, most recently from b74749f to e93ee2e Compare January 14, 2025 21:39
@jpschorr jpschorr force-pushed the feat-shape-category branch from e93ee2e to d9dee1f Compare January 14, 2025 21:49
Base automatically changed from feat-shape-category to main January 14, 2025 23:22
@jpschorr jpschorr changed the base branch from main to feat-paramaterized-equality January 15, 2025 00:40
Base automatically changed from feat-paramaterized-equality to main January 15, 2025 23:25
@jpschorr jpschorr force-pushed the dev-boxed-variant branch 2 times, most recently from b3d26c1 to 0da758c Compare January 24, 2025 01:56
@jpschorr jpschorr force-pushed the dev-boxed-variant branch 8 times, most recently from ebd579e to e168272 Compare January 28, 2025 18:42
@jpschorr jpschorr force-pushed the dev-boxed-variant branch 7 times, most recently from d12a9b1 to 73b6785 Compare January 30, 2025 22:40
@jpschorr jpschorr force-pushed the dev-boxed-variant branch 3 times, most recently from 0f8bf86 to 48b1faf Compare January 31, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant