Adds the COLL_* functions (COLL_AVG, COLL_COUNT, COLL_MAX, COLL_MIN, COLL_SUM) #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
+ Coverage 81.44% 81.46% +0.02%
==========================================
Files 51 44 -7
Lines 11579 10903 -676
==========================================
- Hits 9430 8882 -548
+ Misses 2149 2021 -128
☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 2766 Number failing in both: 410 Number passing in Base (425d3cc) but now fail: 0 Number failing in Base (425d3cc) but now pass: 67 The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass: Click here to see
|
jpschorr
reviewed
May 17, 2023
jpschorr
reviewed
May 18, 2023
| #[track_caller] | ||
| fn coll_avg(elems: Vec<&Value>) -> Value { | ||
| if elems.is_empty() { | ||
| Null |
There was a problem hiding this comment.
All of these implementations return Null if the collection is empty. But I don't think any tests or conformance tests exist to verify this.
There was a problem hiding this comment.
They all return Null on an empty collection other than COLL_COUNT which returns 0. Those conformance tests were added in partiql/partiql-tests@f00114d, which doesn't seem to be in this PR. I'll update the test submodule to the more recent version.
jpschorr
approved these changes
May 25, 2023
|
Note: from #372, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
COLL_functions (COLL_AVG,COLL_COUNT,COLL_MAX,COLL_MIN,COLL_SUM). AlsoBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.