address comments

partiql · Nov 19, 2022 · 206fffb · 206fffb
1 parent 6305c9f
commit 206fffb
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/lang/src/org/partiql/lang/eval/physical/operators/RelationalOperatorKind.kt b/lang/src/org/partiql/lang/eval/physical/operators/RelationalOperatorKind.kt
@@ -1,5 +1,7 @@
 package org.partiql.lang.eval.physical.operators
 
+import org.partiql.lang.eval.physical.window.ExperimentalWindowFunc
+
 /**
  * Indicates which physical relational operator a [RelationalOperatorFactory] can create instances of.
  *
@@ -14,7 +16,6 @@ enum class RelationalOperatorKind {
     UNPIVOT,
     FILTER,
     JOIN,
-    // TODO: Remove from experimental once https://github.com/partiql/partiql-docs/issues/31 is resolved and a RFC is approved
     WINDOW,
     OFFSET,
     LIMIT,

diff --git a/lang/src/org/partiql/lang/eval/physical/operators/WindowRelationalOperatorFactory.kt b/lang/src/org/partiql/lang/eval/physical/operators/WindowRelationalOperatorFactory.kt
@@ -1,6 +1,7 @@
 package org.partiql.lang.eval.physical.operators
 
 import org.partiql.lang.domains.PartiqlPhysical
+import org.partiql.lang.eval.physical.SetVariableFunc
 import org.partiql.lang.eval.physical.window.ExperimentalWindowFunc
 import org.partiql.lang.eval.physical.window.WindowFunction
 
@@ -24,5 +25,9 @@ abstract class WindowRelationalOperatorFactory(name: String) : RelationalOperato
 class CompiledWindowFunction(
     val func: WindowFunction,
     val parameters: List<ValueExpression>,
+    /**
+     * This is [PartiqlPhysical.VarDecl] instead of [SetVariableFunc] because we would like to access the index of variable in the register
+     * when processing rows within the partition.
+     */
     val windowVarDecl: PartiqlPhysical.VarDecl
 )
diff --git a/lang/src/org/partiql/lang/eval/physical/window/Lag.kt b/lang/src/org/partiql/lang/eval/physical/window/Lag.kt
@@ -6,6 +6,7 @@ import org.partiql.lang.eval.physical.EvaluatorState
 import org.partiql.lang.eval.physical.operators.ValueExpression
 
 // TODO: Remove from experimental once https://github.com/partiql/partiql-docs/issues/31 is resolved and a RFC is approved
+// TODO: Decide if we should reduce the code duplication by combining lead and lag function
 @ExperimentalWindowFunc
 internal class Lag : NavigationWindowFunction() {
     override val name = "lag"

diff --git a/lang/src/org/partiql/lang/eval/physical/window/Lead.kt b/lang/src/org/partiql/lang/eval/physical/window/Lead.kt
@@ -6,6 +6,7 @@ import org.partiql.lang.eval.physical.EvaluatorState
 import org.partiql.lang.eval.physical.operators.ValueExpression
 
 // TODO: Remove from experimental once https://github.com/partiql/partiql-docs/issues/31 is resolved and a RFC is approved
+// TODO: Decide if we should reduce the code duplication by combining lead and lag function.
 @ExperimentalWindowFunc
 internal class Lead : NavigationWindowFunction() {