Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trivial] vibe include sys.exit #985

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[trivial] vibe include sys.exit #985

merged 1 commit into from
Dec 14, 2023

Conversation

Yurlungur
Copy link
Collaborator

PR Summary

I forgot to add this in PR #982

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@Yurlungur Yurlungur requested review from jdolence and pgrete December 13, 2023 18:42
@Yurlungur Yurlungur self-assigned this Dec 13, 2023
@Yurlungur Yurlungur enabled auto-merge December 14, 2023 15:50
@Yurlungur Yurlungur disabled auto-merge December 14, 2023 16:47
@Yurlungur Yurlungur merged commit 0072037 into develop Dec 14, 2023
49 checks passed
@Yurlungur Yurlungur deleted the jmm/final-vibe-check branch December 14, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgrete pgrete pgrete approved these changes

@jdolence jdolence Awaiting requested review from jdolence

Assignees

@Yurlungur Yurlungur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yurlungur @pgrete @jonahm-LANL