Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trivial] remove check that got reintroduced #978

Merged
merged 2 commits into from
Nov 21, 2023
Merged

[trivial] remove check that got reintroduced #978

merged 2 commits into from
Nov 21, 2023

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Nov 21, 2023 •
edited
Loading

PR Summary

In bnd_info.cpp, BindInfoGetSetBndInfo an erroneous check for allocation was accidentally re-added in a recent merge. This PR removes it again.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@Yurlungur Yurlungur added the bug Something isn't working label Nov 21, 2023
@Yurlungur Yurlungur requested a review from lroberts36 November 21, 2023 18:49
@Yurlungur Yurlungur self-assigned this Nov 21, 2023
lroberts36
lroberts36 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@lroberts36 lroberts36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yurlungur Yurlungur enabled auto-merge November 21, 2023 18:56
@Yurlungur Yurlungur merged commit cafe557 into develop Nov 21, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdmullen pdmullen pdmullen approved these changes

@lroberts36 lroberts36 lroberts36 approved these changes

Assignees

@Yurlungur Yurlungur

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yurlungur @lroberts36 @pdmullen @jonahm-LANL