Perform swarm boundary logic on device #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enon into brryan/swarm_comms_prefix
Yurlungur
approved these changes
Aug 20, 2024
19 tasks
brryan
added a commit
that referenced
this pull request
Aug 28, 2024
* working * Clean up implicit captures * OK something isnt working with updating empty_indices * Creating indices works but defragmentation is broken * Defrag works * Switch to persistent scratch memory * Clean up * Fix GPU issues * Fix compile error by cleaning up code * Remove unnecessary check against non-null user swarm BCs * Remove unused function * Formatting * Fiddle with send logic * Perform swarm boundary logic on device (#1154) * First kernel down * Further cleanup * Notes * Send seems to work * Need to promote particles example to latest pattern * May have fixed particles example * cycles... * iterative tasking is only iterating on one meshblock in particles example... * Still not working... * New loop seems to work * Cleaned up some printfs/marked unused code for deletion * New algorithm is cycling, time to clean up * Fixed indexing bug... * Clean up * finished_transport shouldnt be provided by swarm * Reverting to old manual iterative tasking * Still working... * Starting to make progress... * Cleaned up * format * A few leftover print statements * Oops ParArray1D isn't a host array when compiled for device * implicit this-> * bug in nrecvd particles with 1 particle received... * Found the bug * Fixed bug, cleaned up * kokkos parallel_scan -> par_scan * Fix types, clean up code * Add warning if using swarms but Real != double * Cleanup from debugging --------- Co-authored-by: Luke Roberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Merging my swarm communication-specific fixes into
brryan/more_swarm_prefix_sumswhich is already an open PRPR Checklist