Small: Fix bug in sparse packs that include fluxes #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lroberts36
changed the title
pgrete
approved these changes
May 23, 2024
Comment on lines
216
to
+222
| if (pv->IsSet(Metadata::Face)) { | ||
| pack.pack_h_(0, b, idx).topological_element = | ||
| TopologicalElement::E1; | ||
| TopologicalElement::F1; | ||
| pack.pack_h_(1, b, idx).topological_element = | ||
| TopologicalElement::E2; | ||
| TopologicalElement::F2; | ||
| pack.pack_h_(2, b, idx).topological_element = | ||
| TopologicalElement::E3; | ||
| TopologicalElement::F3; |
There was a problem hiding this comment.
It was, but I don't think anyone code has actually used this information.
| if (desc.with_fluxes) { | ||
| pack.flx_idx_ = 1; | ||
| if (contains_face_with_fluxes) { | ||
| leading_dim += 5; |
There was a problem hiding this comment.
5 because of the face itself and 4 edges/fluxes?
There was a problem hiding this comment.
leading_dim starts at 1, so this makes it 6. When a face has fluxes, the face itself has 3 components and the edge flux has 3 components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR fixes sparse packs so that they will correctly include generalized fluxes for face and edge centered fields. Previously, the fluxes were only included in the pack if the field was a cell centered field.
PR Checklist