-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRIVIAL] unsuppress test output #1017
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be very useful. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it!
Quite often I had to manually copy and paste the failed command to get to the error message.
Why didn't it occur to me earlier to suggest that kind of change...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is definitely a significant quality of life improvement for debugging. I also have resorted to copying the command from ctest output and running it by hand.
@pgrete and/or someone else who knows the CI: I'm very confused. The CI is complaining that files I didn't change are unformatted, and the relevant lines aren't in this branch. Any ideas what's happening? |
Unclear. Maybe a cosmic ray particle hit the memory of the CI machine? :D |
Fixed now anyway lol |
PR Summary
Regression test outputs suppress both stdout and stderr from the driver. When debugging this is annoying. Since things are integrated with
ctest
andctest
suppresses output for tests that pass (or fail) by default anyway, it's also redundant. This PR makes output (when you ask ctest to be verbose) significantly more verbose, by including driver stdout/stderr output.The main benefit of this is we now see, e.g.,
PARTHENON_THROW
,PARTHENON_FAIL
,PARTHENON_REQUIRE
outputs and any print statements we add by hand when debugging tests. The main disadvantage is that output is way more verbose. It may also slightly change performance but not by much I think.PR Checklist