Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correlation CRUD operations #417

Merged
merged 93 commits into from
Jan 17, 2025
Merged

Conversation

praveen5959
Copy link
Contributor

No description provided.

@praveen5959 praveen5959 self-assigned this Jan 13, 2025
Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
@pranavgoel29
@praveen5959
praveen5959 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@praveen5959 praveen5959 marked this pull request as ready for review January 14, 2025 08:48
const { setTimeRange } = appStoreReducers;
export const useCorrelationsQuery = () => {
const [{ correlationId }, setCorrelatedStore] = useCorrelationStore((store) => store);
const [, setAppStore] = useAppStore((store) => store);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of returning the entire store u can return nil which will still return the setAppStore reducer

@nitisht nitisht merged commit e94a62e into parseablehq:main Jan 17, 2025
1 of 4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants