Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orchestrator): use tmp dir when we create paras artifacts #1638

Merged
merged 9 commits into from
Jan 2, 2024

Conversation

pepoviola
Copy link
Collaborator

Use tmp dir for export-genesis-state cmd.
Fix #1519
cc: @JoshOrndorff

@JoshOrndorff
Copy link

The core change looks good to me. Just out of curiosity, why was downgrading chai necessary?

@pepoviola
Copy link
Collaborator Author

The core change looks good to me. Just out of curiosity, why was downgrading chai necessary?

Thanks for the feedback @JoshOrndorff. The issue with chai was caused by the depedabot that bump the major version of chai and that version drop cjs support, so we need to adjust some parts of our code. I will make the change in a separate pr.

Thx!

@pepoviola
Copy link
Collaborator Author

ci cache here is causing troubles, I will close this one and re-open with a diff branch.
Thx!

@pepoviola pepoviola closed this Jan 2, 2024
@pepoviola pepoviola mentioned this pull request Jan 2, 2024
@pepoviola pepoviola reopened this Jan 2, 2024
@pepoviola pepoviola merged commit 80224c3 into main Jan 2, 2024
33 checks passed
@pepoviola pepoviola deleted the fix-1519 branch January 2, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly specify a data directory when exporting parachain genesis state
2 participants