Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with relative path in web worker #169

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Fix issue with relative path in web worker #169

merged 3 commits into from
Jan 22, 2025

Conversation

smiasojed
Copy link
Collaborator

@smiasojed smiasojed commented Jan 17, 2025

Remove reloading of the resolc.js file.

@xermicus
Copy link
Member

I didn't expect to time it out especially with the bumped limits. Why is it so much worse if it's a single file?

@athei
Copy link
Member

athei commented Jan 17, 2025

Maybe just (memory) problems with very large text files?

@smiasojed
Copy link
Collaborator Author

Maybe just (memory) problems with very large text files?

Yes, it is a memory problem caused by the SINGLE_FILE option. It seems that this is implemented in a non-optimal way.

@smiasojed smiasojed merged commit 888723e into main Jan 22, 2025
6 checks passed
@xermicus xermicus deleted the sm/fix-paths branch January 23, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants