Testing workflows #164
Testing workflows #164
Conversation
mutantcornholio
force-pushed
the
yuri/pr-workflows
branch
3 times, most recently
from
64abd5b to
804cbaf
Compare
mutantcornholio
force-pushed
the
yuri/pr-workflows
branch
13 times, most recently
from
27f70dd to
9b757b6
Compare
mutantcornholio
force-pushed
the
yuri/pr-workflows
branch
from
9b757b6 to
7914fe4
Compare
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| # TODO: move this setup into a reusable docker image; |
There was a problem hiding this comment.
The tests should run on Windows and MacOS too; instead of a docker image it seems to me we rather make a matrix?
| Command::cargo_bin(common::REVIVE_LLVM)? | ||
| .current_dir(test_dir.path()) | ||
| .arg("build") | ||
| .arg("--llvm-projects") | ||
| .arg("clang") | ||
| .arg("--llvm-projects") | ||
| .arg("lld") | ||
| .assert() | ||
| .success(); |
There was a problem hiding this comment.
Marking it here but can you remove the builtins command below as a drive-by? The builtins are built anyways during the build command.
| Command::cargo_bin(common::REVIVE_LLVM)? | ||
| .current_dir(test_dir.path()) | ||
| .arg("build") | ||
| .arg("--llvm-projects") | ||
| .arg("clang") | ||
| .arg("--llvm-projects") | ||
| .arg("lld") | ||
| .assert() | ||
| .success(); | ||
|
|
There was a problem hiding this comment.
Shouldn't this and the below command be merged? This here builds LLVM, clang and LLD. Below builds LLVM with tests and coverage.
| @@ -116,6 +136,16 @@ fn build_with_sanitizers() -> anyhow::Result<()> { | |||
| .assert() | |||
| .success(); | |||
|
|
|||
| Command::cargo_bin(common::REVIVE_LLVM)? | |||
| .arg("--llvm-projects") | ||
| .arg("clang") |
There was a problem hiding this comment.
| .arg("--llvm-projects") | |
| .arg("clang") |
We should only need LLD; this will make the test consume less resources.
|
|
||
| jobs: | ||
| test: | ||
| runs-on: parity-large |
There was a problem hiding this comment.
We will release on Windows and MacOS too, so this probably should be a matrix test with those platforms to avoid any problems during releasing.
|
Okay, taking this PR back to draft, let's see how win & mac will run the tests |
No description provided.