Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transfer on rococo #353

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix transfer on rococo #353

merged 1 commit into from
Oct 17, 2023

Conversation

mordamax
Copy link
Contributor

@mordamax mordamax commented Oct 17, 2023 •
edited
Loading

transfer is undefined now for some reason (reason -> paritytech/polkadot-sdk#1226)
replaced with trasferKeepAlive

image

The reason is valid, as transfer was actually transfer_allow_death, while we supposed to use transfer_keep_alive from the start

@mordamax mordamax requested a review from a team as a code owner October 17, 2023 20:43
Bullrich
Bullrich approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@Bullrich Bullrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple lib upgrade 😄

@mordamax mordamax merged commit 0cc808d into main Oct 17, 2023
3 checks passed
@mordamax mordamax deleted the mak-fix branch October 17, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzadp rzadp rzadp approved these changes

@Bullrich Bullrich Bullrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mordamax @Bullrich @rzadp