find_potential_parents: Enforce max_depth from the pending_block
#7335
+90
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `max_depth` is checked from the `included_block`. However, we should always be interested to build on the `pending_block` that will be the next included block. Thus, enforcing the `max_depth` from `pending_block` is the more correct option here. Especially for chains that are running with a higher block frequency than the relay chain and thus, having more than one block between `included_block` and `pending_block`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
max_depthis checked from theincluded_block. However, we should always be interested to build on thepending_blockthat will be the next included block. Thus, enforcing themax_depthfrompending_blockis the more correct option here. Especially for chains that are running with a higher block frequency than the relay chain and thus, having more than one block betweenincluded_blockandpending_block.