transfer function Preservation is changed to Expendable #7243
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscoaguirre
approved these changes
Jan 20, 2025
Co-authored-by: Francisco Aguirre <[email protected]>
|
Review required! Latest push from author must always be reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7039
The Preservation of transfer method of fungible and fungibles adapters is changed from Preserve to Expendable. So the behavior of the TransferAsset will be consistent with the WithdrawAsset function, as in fungible and fungibles adapter.
This pull request includes changes to the
fungible_adapter.rsandfungibles_adapter.rsfiles in thepolkadot/xcm/xcm-builderdirectory. The main change involves modifying the transfer method to use theExpendablestrategy instead of thePreservestrategy.Changes to transfer strategy:
polkadot/xcm/xcm-builder/src/fungible_adapter.rs: Changed the transfer method to useExpendableinstead ofPreserve.polkadot/xcm/xcm-builder/src/fungibles_adapter.rs: Changed the transfer method to useExpendableinstead ofPreserve.