Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable2412] Backport #6855 #7090

Open
wants to merge 1 commit into
base: stable2412
Choose a base branch
from
Open

[stable2412] Backport #6855 #7090

wants to merge 1 commit into from
+478 −31

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]
Copy link

Backport #6855 into stable2412 from alistair-singh.

See the documentation on how to use this bot.

@alistair-singh @github-actions
Snowbridge: Support bridging native ETH (#6855)
ec4d7e0 
Changes:
1. Use the 0x0000000000000000000000000000000000000000 token address as
Native ETH.
2. Convert it to/from `{ parents: 2, interior:
X1(GlobalConsensus(Ethereum{chain_id: 1})) }` when encountered.

Onchain changes:
This will require a governance request to register native ETH (with the
above location) in the foreign assets pallet and make it sufficient.

Related solidity changes:
Snowfork/snowbridge#1354

TODO:
- [x] Emulated Tests

---------

Co-authored-by: Vincent Geddes <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
(cherry picked from commit 4059282)
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Jan 8, 2025
Merged
1 task
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Jan 8, 2025
@paritytech-review-bot paritytech-review-bot bot requested a review from a team January 8, 2025 14:21
@acatangiu
Copy link
Contributor

cc @alistair-singh

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acatangiu @alistair-singh