-
Notifications
You must be signed in to change notification settings - Fork 766
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
upgraded review bot to v2.1.0 (#1908)
Upgraded to version 2.1.0 which has paritytech/review-bot#94, a change in the logic of the action to overcome some problems with permissions coming from PRs from forks For this, we needed to divide the actions into two files: - A first action that triggers on PRs and reviews and uploads the PR number. - A second action which is triggered under the completion of the first one and runs as the action normally runs (but won't have any problems regarding permissions because it is triggered from the master branch)
- Loading branch information
Showing
2 changed files
with
42 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,10 @@ | ||
name: Review PR | ||
name: Review Bot | ||
on: | ||
pull_request_target: | ||
workflow_run: | ||
workflows: | ||
- Review-Trigger | ||
types: | ||
- opened | ||
- reopened | ||
- synchronize | ||
- review_requested | ||
- review_request_removed | ||
- ready_for_review | ||
pull_request_review: | ||
- completed | ||
|
||
permissions: | ||
contents: read | ||
|
@@ -17,6 +13,11 @@ jobs: | |
review-approvals: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Extract content of artifact | ||
id: number | ||
uses: Bullrich/[email protected] | ||
with: | ||
artifact-name: pr_number | ||
- name: Generate token | ||
id: team_token | ||
uses: tibdex/github-app-token@v1 | ||
|
@@ -29,3 +30,4 @@ jobs: | |
repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
team-token: ${{ steps.team_token.outputs.token }} | ||
checks-token: ${{ steps.team_token.outputs.token }} | ||
pr-number: ${{ steps.number.outputs.content }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
name: Review-Trigger | ||
|
||
on: | ||
pull_request_target: | ||
types: | ||
- opened | ||
- reopened | ||
- synchronize | ||
- review_requested | ||
- review_request_removed | ||
- ready_for_review | ||
pull_request_review: | ||
|
||
jobs: | ||
trigger-review-bot: | ||
runs-on: ubuntu-latest | ||
name: trigger review bot | ||
steps: | ||
- name: Get PR number | ||
env: | ||
PR_NUMBER: ${{ github.event.pull_request.number }} | ||
run: | | ||
echo "Saving PR number: $PR_NUMBER" | ||
mkdir -p ./pr | ||
echo $PR_NUMBER > ./pr/pr_number | ||
- uses: actions/upload-artifact@v3 | ||
name: Save PR number | ||
with: | ||
name: pr_number | ||
path: pr/ | ||
retention-days: 5 |