send to sentry if error #19
Conversation
lib/logger.js
Outdated
| @@ -234,6 +244,10 @@ function logToConsole(type, sender, msgShort, _extras) { | |||
| if (!checkType(type)) return; | |||
| if (!logThis(type)) return; | |||
|
|
|||
| if (_extras instanceof Error) { | |||
There was a problem hiding this comment.
I don't think it is a good approach to handle errors and log them in Sentry through some shared package.
There was a problem hiding this comment.
what problem do you see?
the current thing is that we write the same code over and over. we could hide it in a function within the same repo but then we copy past the same function to x repos and need to maintain them.
from a clean arch perspective this is polluting our code base it has no business value but as a developer you need to know about it.
There was a problem hiding this comment.
Configuration: Each project may have different requirements for logging, such as different log levels or different destinations for logs. If the Sentry logger is defined in a shared package, it may not be possible to configure it differently for each project.
Maintenance: If the Sentry logger is defined in a shared package, any changes to the logger will affect all projects that use the package. This can make it difficult to maintain the logger and ensure that it works correctly for each project.
Dependencies: The Sentry logger may have dependencies on other packages or libraries that are not compatible with all projects. If the logger is defined in a shared package, it may be difficult to manage these dependencies and ensure that they work correctly for each project.
There was a problem hiding this comment.
configuration: I guess answered in the other comment
maintenance: 4 changes in 3 years... I'm willing to take the risk^^
dependencies: versioning
| sentry = { | ||
| dsn: isProd ? process.env.SENTRY_DNS : undefined, | ||
| integrations: [new Dedupe()], // dedupe based on fingerprint and stack trace | ||
| tracesSampleRate: 1, // 100% of all errors will be reported | ||
| environment: isProd ? 'production' : 'testing', | ||
| serverName: require('os').hostname() | ||
| } | ||
| const Sentry = require('@sentry/node') | ||
| Sentry.init({ dsn: sentry.dsn }) | ||
|
|
There was a problem hiding this comment.
I mean, with this code you must be 1000% sure that you use same settings everywhere
There was a problem hiding this comment.
that's just a draft... of course the must be removed. the config belongs the the repos using it.
it's just about protecting the code from sentry
is the enough to protect the code from sentry or do we need more?