profiler: Add batch ebpf map operations (reloaded) #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
v-thakkar
reviewed
Jul 19, 2022
| // We are getting and deleting the whole map, so there should not be a next batch. | ||
| if nextCountKey != uintptr(0) { | ||
| level.Debug(p.logger).Log("msg", "Next batch should be null", "nextBatch", nextCountKey) | ||
| } |
There was a problem hiding this comment.
I like that we're checking this 🎉
|
LGTM! |
javierhonduco
approved these changes
Jul 20, 2022
We only document it and don't actually force any minikube iso version (except e2e tests cc @Sylfrena). I have already updated the documentation in repo and I have a PR to update parca.dev
Will do 👍 |
|
Was thinking of batch BPF operations in the context of cleaning up maps. Let's not forget to take a look at the profiles and see if it could be worth it to batch-delete our maps 😄 |
|
Some quick data (https://pprof.me/3f07325):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kemal Akkoyun [email protected]