Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based off @kakkoyun's work to use libbpf(go)'s batch APIs.
Context
The main issue we found while working with this API was that they were erroring with
EPERM
.After some debugging, we realised that libbpf wasn't handling errors in the way we
expected.
The debugging write-up and more context can be found here,
and the fix is in this PR.
After landing these changes upstream, we pointed to the updated libbpfgo version, as well as added
some regression tests to ensure that libbpfgo
behaves as expected, and to make it easier in the future to write further compatibility tests.
Note: the rest of the batch APIs error handling is still unfixed. Tracking in aquasecurity/libbpfgo#162.
Test plan
Checking that elements are deleted
entries are deleted in batch:
Crosschecked with
bpftool
:CPU profiles are still working fine
With:
Which is accurate and correct 🎉