pkg/agent: Use eBPF map batch operations #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekparker
changed the title
derekparker
force-pushed
the
ebpf-batch-map
branch
3 times, most recently
from
e91265d to
40ceae5
Compare
derekparker
changed the title
derekparker
force-pushed
the
ebpf-batch-map
branch
from
13b2588 to
772ae82
Compare
kakkoyun
approved these changes
Jan 13, 2022
| @@ -53,6 +54,16 @@ const ( | |||
| doubleStackDepth = 254 | |||
| ) | |||
|
|
|||
| // stackCountKey mirrors the struct in parca-agent.bpf.c. | |||
| // | |||
| // TODO(derekparker) Perhaps in order to keep these in sync we should write a Go generator to | |||
There was a problem hiding this comment.
Already the opened the issue for it #207
|
|
||
| stackBytes, err := stackTraces.GetValue(unsafe.Pointer(&userStackID)) | ||
| if err != nil { | ||
| //profile.MissingStacks++ | ||
| // TODO(derekparker): Should we log or increment missing stack trace count? |
There was a problem hiding this comment.
👍 Let's add a metric for it, not necessarily in this PR though. #208
| // memsetCountKeys will reset the given slice to the given value. | ||
| // This function makes use of the highly optimized copy builtin function | ||
| // and is able to fill the entire slice in O(log n) time. | ||
| func memsetCountKeys(in []stackCountKey, v stackCountKey) { |
This patch adds support for using eBPF batch operations on maps which should dramatically improve the performance of the parca-agent by enabling it to batch lookup and delete keys/values in maps in a single operation. This replaces the use of iterators in favor of iteration in batches. Fixes parca-dev#74
derekparker
force-pushed
the
ebpf-batch-map
branch
from
772ae82 to
e528c7c
Compare
Done! |
kakkoyun
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for using eBPF batch operations on maps which
should dramatically improve the performance of the parca-agent by
enabling it to batch lookup and delete keys/values in maps in a single
operation.
This replaces the use of iterators in favor of iteration in batches.
Fixes #74