Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rm unused error variants #14183

Merged
merged 1 commit into from
Feb 3, 2025
Merged

chore: rm unused error variants #14183

merged 1 commit into from
Feb 3, 2025
+5 −44

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 3, 2025

none of those were used.

the only weird one is the pre-merge error check which I believe was legacy engine specific.
we can remove this

@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-observability Related to tracing, metrics, logs and other observability tools labels Feb 3, 2025
Rjected
Rjected approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, iirc there are no merge tests any more so we can remove the pre merge error

@mattsse mattsse added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit af3eb83 Feb 3, 2025
45 checks passed
@mattsse mattsse deleted the matt/rm-unused-error-variants2 branch February 3, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected