Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: abstract OpBeaconConsensus over primitives and chainspec #14171

Merged
merged 1 commit into from
Feb 4, 2025
Merged

feat: abstract OpBeaconConsensus over primitives and chainspec #14171

merged 1 commit into from
Feb 4, 2025
+241 −222

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Feb 3, 2025

Abstracts OpBeaconConsensus over primitives and chainspec. I've moved the holecene methods into free functions in optimism-consensus crate so that we don't need concrete OpChainSpec for those

@klkvr klkvr added the A-sdk Related to reth's use as a library label Feb 3, 2025
mattsse
mattsse approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

emhane
emhane approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all for countering ossification, l3 be welcomed

@emhane emhane added the A-op-reth Related to Optimism and op-reth label Feb 4, 2025
@klkvr klkvr added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 07090b3 Feb 4, 2025
45 checks passed
@klkvr klkvr deleted the klkvr/generic-op-consensus branch February 4, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane emhane approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klkvr @mattsse @emhane