chore: Improve Logging, RPC Extension, and JSON-RPC Compatibility #14150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Feb 1, 2025
|
|
||
| ctx.modules.merge_configured(ext.into_rpc())?; | ||
| tracing::info!("txpool extension enabled"); // Improved logging |
There was a problem hiding this comment.
Suggested change
| tracing::info!("txpool extension enabled"); // Improved logging | |
| tracing::info!("txpool extension enabled"); |
Comment on lines
-27
to
-29
| if !args.enable_ext { | ||
| return Ok(()) | ||
| } |
There was a problem hiding this comment.
I prefer this because this removes one indent
Comment on lines
-31
to
-36
| // here we get the configured pool. | ||
| let pool = ctx.pool().clone(); | ||
|
|
||
| let ext = TxpoolExt { pool }; | ||
|
|
||
| // now we merge our extension namespace into all configured transports |
There was a problem hiding this comment.
I want to keep these docs because this is an example and these provide helpful context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a few inconsistencies and improved overall clarity:
Better Logging with
tracingprintln!("txpool extension enabled");withtracing::info!for structured logging.tracing_subscriber::fmt::init();to initialize proper logging.Optimized RPC Module Extension
if !args.enable_ext { return Ok(()); }, making the logic cleaner.args.enable_ext == true.Fixed JSON-RPC API Types
usizetou64for better JSON-RPC client compatibility.Improved CLI Argument Parsing
#[derive(...)]from#[arg(long)].Enhanced Tests with a Mock Transaction Pool
MockTransactionPool, replacingNoopTransactionPool.