perf(mdbx): do not always collect the backtrace of a locked transaction #14123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-perf
mattsse
approved these changes
Jan 31, 2025
| @@ -586,8 +586,9 @@ impl TransactionPtr { | |||
| tracing::debug!( | |||
| target: "libmdbx", | |||
| txn = %self.txn as usize, | |||
| backtrace = %std::backtrace::Backtrace::force_capture(), | |||
| "Transaction lock is already acquired, blocking..." | |||
| backtrace = %std::backtrace::Backtrace::capture(), | |||
There was a problem hiding this comment.
this should now just be an atomic load so this is better since this path is now reachable more often
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can greatly affect the performance, so instead we should only collect the backtrace if
RUST_BACKTRACE=1env variable is set.